Added a new option to the config object so $created_config can be passed through to underlying CloudWatch package #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #42 which was merged around 3 weeks ago has shifted from using This PR might need amendments to support An update to this PR would definitely help. |
|
Hey Dinesh,
Like most overworked engineers these days, I'll have to first get my head
back around what the PR even did. We pointed our implementation of this
project at the fork for *some* reason that now escapes me.
I'll try to take a look in the am.
…On Wed, Sep 20, 2023, 11:04 PM Danish Nadaf ***@***.***> wrote:
With #42 <#42>
which was merged around 3 weeks ago has shifted from using
Maxbanton\Cwh\Handler\Cloudwatch to PhpNexus\Cwh\Handler\Cloudwatch
package.
This PR might need amendments to support PhpNexus package which also
supports an additional param $creatStream to further reduce API calls to
AWS in case LogGroup and LogStream both already exist - reference docs
<https://github.com/phpnexus/cwh#advanced-usage>
An update to this PR would definitely help.
Thanks in advance! :)
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZOD2JQTSA3PNUEARHJISFDX3O4GDANCNFSM6AAAAAATSQ4ZVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
throttlehead-dev
changed the title
Merge latest changes from forked package
|
I wanted to note here that this does appear to be a breaking change for people who are < laravel 10. You guys have The problem is that if it has to resolve to an older version, it actually resolves to a version of the code that still has the If I try to force 3.0 in our project, I get a conflict with monolog 3.0: I wont really be able to test the changes in our project, nor upgrade to them, so we'll have to limp along with our fork for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36
This is a small update that passes through a new
created_configoption to the underlying logger.Best practices are to setup logging groups and permissions for them and only give your web service permission to these specific group names and/or prefixes. Since our groups were already created in our infra code, we would get an error when trying to log to them because it would always try to create the group and not have permission to do any of the operations required for checking and creating log groups.
This simply allows you to set this to
falsein the config and ensure the underlying package doesn't try to do any of this stuff.