Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Changes to several trainer classes #5505

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

Fontbane
Copy link
Contributor

@Fontbane Fontbane commented Mar 11, 2025

What are the changes the user will see?

  • Biker, Baker, Beauty and Parasol Lady Trainer classes have revamped teams
  • Hex Maniacs can spawn with Psychic-types as well as Ghost-types
  • Cyclists have their species pool tweaked
**Biker** *The Biker previously chose random Poison-types. They now have a proper pool of species they pull from.*
Tier Mons
Common Ekans, Koffing, Croagunk, Venipede, Scraggy
Uncommon Grimer, Voltorb, Teddiursa, Magby, Skorupi, Sandile, Pawniard, Shroodle
Rare Varoom, Cyclizar
**Beauty** *The Beauty previously had nothing defined regarding party members.*
Tier Mons
Common Meowth, Goldeen, Mareep, Marill, Skitty, Glameow, Purrloin
Uncommon Smoochum, Roselia, Luvdisc, Blitzle, Sewaddle, Petilil, Minccino, Gothita, Spritzee, Flittle
Rare Feebas, Furfrou, Salandit, Bruxish, Hatenna, Snom, Alolan Vulpix
Super Rare Clamperl, Amaura, Sylveon, Goomy, Popplio

Dancer now has Quaxly and Jangmo-o instead of Popplio in Super Rare

**Cyclist**
Tier Mons
Common Doduo, Pichu, Taillow, Starly, Ponyta
Uncommon Electrike, Shinx, Blitzle, Ducklett, Wattrel
Rare Yanmega, Ninjask, Whirlipede, Emolga, Skiddo
Super Rare Accelgor, Dreepy
**Baker**

Previously, the Baker would use Grass- or Fire-types.
Baker will now use mons which match any of these criteria:

  • Mons who get any of these abilities naturally (not including passives)
    • White Smoke
    • Gluttony
    • Honey Gather
    • Harvest
    • Cheek Pouch
    • Sweet Veil
    • Ripen
    • Purifying Salt
    • Well-Baked Body
    • Supersweet Syrup
    • Hospitality
  • Mons who learn any of these moves via level up
    • Soft-Boiled
    • Spore
    • Overheat
    • Teatime
    • Milk Drink
**Parasol Lady**

Previously, Parasol Lady would just get random Water-types.
Parasol Lady now uses mons which match any of the following criteria:

  • Mons who get any of these abilities naturally (not including passives)
    • Drizzle
    • Swift Swim
    • Hydration
    • Rain Dish
    • Dry Skin
    • Wind Power
  • Mons who learn any of these moves via level up
    • Rain Dance

The following Trainers have been moved around:

  • Beauty is now Common in Metropolis and Meadow
  • Baker is now Uncommon in Meadow
  • Parasol Lady is no longer found in Beach
  • Parasol Lady is now Common in Swamp and Lake
  • Hex Maniac is now Uncommon in Ruins
  • Backpacker is now Uncommon in Desert

Why am I making these changes?

What are the changes from a developer perspective?

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@EscaShark
Copy link
Contributor

EscaShark commented Mar 11, 2025

Some changes I'd make

  • Biker should get Grimer, being a staple species of the class in their debut gen. I would consider Teddiursa and Drowzee as well. Electrike feels extremely random (as does Shroodle but it matches in type at least)--Joltik would be a better option for a second Electric-type, as one biker in BW actually uses it, while Galv has a comparable power level to Manectric. Finally Bouffalant would fit nicely in Uncommon or Rare as well, being on a BW biker, fitting thematically with its tough look and adding a high-BST single stage mon.

  • Beauty kind of uses whatever she wants in the core series so any pool would fit really but I'd still like to see Elekid on here.

  • While we're changing Cyclist, we could consider putting Ducklett on them for some type variety. Not having Shinx is a bit weird since multiple Cyclists use it but they do have a lot of Electrics already, maybe it could go over Electrike (none of them use it to my knowledge)?

  • For Baker, I would add the following abilities: Cheek Pouch, Cud Chew, Gulp Missile. I would add the following moves: Salt Cure. (I was considering Swallow but the pool of mons with it is pretty sizable and adds a couple "random" ones. Matcha Gotcha also looks fun in the code but won't do anything since Sinis already has Hospitality 🤷)

  • As for the Parasol Lady, I would remove the Weather Ball requirement. Not many mons get this via levelup, but as for the ones that do, Bronzong already gets in via Rain Dance, and Glalie/Eiscue don't fit the rain theme at all. You'd only add Bellibolt as far as I'm aware who isn't worth the two weirdos. I would furthermore consider putting Electro Shot, as Arch is typically associated with Rain (Stalwart could work if you want Duralu to appear on lower levels but doesn't fit the Rain theme). Lastly we could put Wind Power to make Kilowattrel spawn too but this isn't completely necessary, at least the Wind Power--rain link is easier to see than Stalwart--rain.

Lastly could you confirm that the methods to spawn mons based on movepool/abilities/etc. leave out cover legends and the like? I don't think anyone's hyped to fight a Parasol Lady with a Lugia...

@Madmadness65 Madmadness65 added Game Balance Changes focused on game balance Balance Team Specifically a balance team change labels Mar 11, 2025
@Fontbane
Copy link
Contributor Author

Fontbane commented Mar 11, 2025

Some changes I'd make

  • Biker should get Grimer, being a staple species of the class in their debut gen. I would consider Teddiursa and Drowzee as well. Electrike feels extremely random (as does Shroodle but it matches in type at least)--Joltik would be a better option for a second Electric-type, as one biker in BW actually uses it, while Galv has a comparable power level to Manectric. Finally Bouffalant would fit nicely in Uncommon or Rare as well, being on a BW biker, fitting thematically with its tough look and adding a high-BST single stage mon.
  • Beauty kind of uses whatever she wants in the core series so any pool would fit really but I'd still like to see Elekid on here.
  • While we're changing Cyclist, we could consider putting Ducklett on them for some type variety. Not having Shinx is a bit weird since multiple Cyclists use it but they do have a lot of Electrics already, maybe it could go over Electrike (none of them use it to my knowledge)?
  • For Baker, I would add the following abilities: Cheek Pouch, Cud Chew, Gulp Missile. I would add the following moves: Salt Cure. (I was considering Swallow but the pool of mons with it is pretty sizable and adds a couple "random" ones. Matcha Gotcha also looks fun in the code but won't do anything since Sinis already has Hospitality 🤷)
  • As for the Parasol Lady, I would remove the Weather Ball requirement. Not many mons get this via levelup, but as for the ones that do, Bronzong already gets in via Rain Dance, and Glalie/Eiscue don't fit the rain theme at all. You'd only add Bellibolt as far as I'm aware who isn't worth the two weirdos. I would furthermore consider putting Electro Shot, as Arch is typically associated with Rain (Stalwart could work if you want Duralu to appear on lower levels but doesn't fit the Rain theme). Lastly we could put Wind Power to make Kilowattrel spawn too but this isn't completely necessary, at least the Wind Power--rain link is easier to see than Stalwart--rain.

Lastly could you confirm that the methods to spawn mons based on movepool/abilities/etc. leave out cover legends and the like? I don't think anyone's hyped to fight a Parasol Lady with a Lugia...

Weather Ball was supposed to catch Roserade but SwSh got rid of it...
Elekid's only on Elesa's gym trainers and doesn't particularly fit imo
I'll add Cheek Pouch and Purifying Salt on Baker, Ducklett on Cyclist and a couple things to Biker

@Fontbane Fontbane marked this pull request as ready for review March 11, 2025 18:42
@Fontbane Fontbane requested review from a team as code owners March 11, 2025 18:42
@EscaShark
Copy link
Contributor

Cud Chew imo is in the same boat as Gluttony where sure it's not on food mons but the ability itself is heavily food-themed. If we're gonna put stuff like Grumpig and the elemental monkeys in through Gluttony we can live with a Fire Tauros and a Farigiraf.

But even moreso than Cud Chew I want to reiterate Gulp Missile, this is a mon that tries to eat other stuff during battle. Also reminded me that Fillet Away is a thing, could be added too.

Sure it's not "baking" but Teatime and Milk Drink and the like aren't directly tied to baking either, just food as a whole.

@Fontbane
Copy link
Contributor Author

Sorry sir this is a seafood-free bakery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change Game Balance Changes focused on game balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants