[BUG] Fix Locked Reroll not using Luck Score

[Scoooom]

What are the changes the user will see?

When locking your reroll using Lock Capsule, it now correctly uses your Luck Value

Why am I making these changes?

It is currently simply counting the number of shiny pokemon you have. I suspect this was an older method of handling luck. This will also fix #4308

What are the changes from a developer perspective?

Stop using partyShinyCount and instead use getPartyLuckValue.

I will note, I was unsure if using the old upgradeOdds method, or the old one which uses different Math.floor formula.

Math.floor(32 / ((partyShinyCount + 2) / 2));

VS

Math.floor(128 / ((partyLuckValue + 4) / 4));

Screenshots/Videos

N/A

How to test the changes?

Check that locked rerolls are giving the proper upgrades. I will note this change may massively affect endless runs where locked rerolls occur most often.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

• Has a locales PR been created on the locales repo?
  • If so, please leave a link to it here:
• Has the translation team been contacted for proofreading/translation?

[damocleas]

math and all that seems correct, one person testing without automation is impossible to check without just "feeling lucky" so didn't do much extra besides making sure it wasn't broken