[GitHub] Automatically add issue-type in issue templates #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows automatically marking the type of issues made with the template
Madmadness65
added
the
GitHub
Madmadness65
approved these changes
Mar 8, 2025
SirzBenjie
requested review from
a team,
damocleas,
Xavion3,
DayKev and
Wlowscha
and removed request for
a team
DayKev
approved these changes
Mar 9, 2025
damocleas
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
As a pokerogue player, none. As a user making a new issue on GitHub -- the pretty "type" label will automatically be added when using an issue template.
Why am I making these changes?
I like things being nice, neat, orderly, and in their place. GitHub introduced a wonderful feature called issue types somewhat recently. They are beautiful and make it easier to filter issues. They also reduce noise and clutter in issue titles that are overstimulating.
I don't like searching based on the title anyway.
I also really want to remove the title field from the issue template, because it is distracting to me. (I don't like verbosity, can't you tell?); you can easily discern the kind of issue from the colorful
typefield.However, I will leave that for another PR as I assume, for the purposes of the discord webhook, that we still want to be able to easily discern the issue type.
This is possible with a properly configured webhook, and so I would still very much like to be able to remove the [type] clutter from issue titles in another PR.
What are the changes from a developer perspective?
Added the
type: 'x'line to the issue templates to automatically add the corresponding issue type.Screenshots/Videos
Look how nice these look:
How to test the changes?
Make a new issue? (no actually don't we don't need dummy issues)
Checklist
betaas my base branch[ ] Have I tested the changes manually?[ ] Are all unit tests still passing? (npm run test)[ ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?[ ] Have I provided screenshots/videos of the changes (if applicable)?[ ] Have I made sure that any UI change works for both UI themes (default and legacy)?