Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix #5422 Neutralizing Gas and Legendary Weather Abilities Persist After Flee #5496

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

emdeann
Copy link
Contributor

@emdeann emdeann commented Mar 8, 2025

What are the changes the user will see?

Neutralizing Gas and Primordial Sea/Desolate Land/Delta Stream will clear when the user runs away from an enemy with these abilities.

Why am I making these changes?

Fixes #5422

What are the changes from a developer perspective?

All I'm doing is adding a call to applyPreLeaveFieldAbAttrs for each enemy on the field on flee, along with updating relevant tests with a case for this situation. The call is in a new loop preceding everything else because PreLeaveField should apply before "escaping" (i.e. before the flee success message is played - someone can test this on cart if they want, but im 99% certain as this is how all other interactions with these abilities work).

I'm not using the leaveField() method because it does some extra housekeeping we don't want here (particularly, it would reset the sprite immediately instead of the nice fade animation we have now)

Screenshots/Videos

2025-03-08.00-26-11.mp4

How to test the changes?

Automated tests or overrides with any of the affected abilities

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@emdeann emdeann requested a review from a team as a code owner March 8, 2025 08:29
@emdeann emdeann changed the title Flee [Bug] Fix #5422 Neutralizing Gas and Legendary Weather Abilities Persist After Flee Mar 8, 2025
@Madmadness65 Madmadness65 added Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Beta] Neutralizing Gas and Legendary Weather Abilities Persist After Faint, Capture, Flee
2 participants