[UI/UX] Changed wrong colors in german type icons #5494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The user will see proper colors in the pokémon type icons for Electric type and Fire type. Electric type used to have a green "K" (probably because it was copied from the "K" in "KÄFER" (bug)), and Fire type (FEUER) used to have a darker pixel at the bottom part of the "U".
Why am I making these changes?
When I played using the German translation I noticed that the "K" in the "ELEK" icon for Electric type had a different color. When I checked the spritesheet I also noticed that the "U" in "FEUER" had a miscolored pixel.
What are the changes from a developer perspective?
No changes.
Screenshots/Videos
Electric type before:

Electric type after:

Fire type before:

Fire type after:

How to test the changes?
I used the following override to get a Shinx in order to check its Electric type icon at the beginning of a new run:
The Fire type icon can be checked by using any of the initial Fire-type starters (for example, I used Charmander).
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: