Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Changed wrong colors in german type icons #5494

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

MascaChapas27
Copy link
Contributor

@MascaChapas27 MascaChapas27 commented Mar 7, 2025

What are the changes the user will see?

The user will see proper colors in the pokémon type icons for Electric type and Fire type. Electric type used to have a green "K" (probably because it was copied from the "K" in "KÄFER" (bug)), and Fire type (FEUER) used to have a darker pixel at the bottom part of the "U".

Why am I making these changes?

When I played using the German translation I noticed that the "K" in the "ELEK" icon for Electric type had a different color. When I checked the spritesheet I also noticed that the "U" in "FEUER" had a miscolored pixel.

What are the changes from a developer perspective?

No changes.

Screenshots/Videos

Electric type before:
before-elek

Electric type after:
after-elek

Fire type before:
before-feuer

Fire type after:
after-feuer

How to test the changes?

I used the following override to get a Shinx in order to check its Electric type icon at the beginning of a new run:

const overrides = {
  STARTER_SPECIES_OVERRIDE: Species.SHINX
} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

The Fire type icon can be checked by using any of the initial Fire-type starters (for example, I used Charmander).

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@MascaChapas27 MascaChapas27 requested a review from a team as a code owner March 7, 2025 22:32
@Madmadness65 Madmadness65 added the Sprite/Animation For issues/PRs related to graphics label Mar 7, 2025
@damocleas damocleas enabled auto-merge (squash) March 9, 2025 22:25
@damocleas damocleas merged commit 572556b into pagefaultgames:beta Mar 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprite/Animation For issues/PRs related to graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants