Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix NG crash when ability is reactivated for a Pokemon off the field #5478

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

emdeann
Copy link
Contributor

@emdeann emdeann commented Mar 4, 2025

What are the changes the user will see?

Game won't freeze when neutralizing gas ends on the same turn that a pokemon with a reactivatable ability faints. See https://discord.com/channels/1125469663833370665/1346346653128593518/1346346653128593518

Why am I making these changes?

crashes are bad

What are the changes from a developer perspective?

Simply passing true to getField() in NG calls to activate/deactivate abilities to ensure pokemon are active

How to test the changes?

Use explosion against a pokemon with a legendary weather ability and observe the game not crashing

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@emdeann emdeann requested a review from a team as a code owner March 4, 2025 07:03
@damocleas damocleas added the P1 Bug Major. Game crashing move/ability/interaction label Mar 4, 2025
DayKev
DayKev previously approved these changes Mar 4, 2025
@Wlowscha
Copy link
Contributor

Wlowscha commented Mar 4, 2025

Should we add a test for this just to stay safe?

@emdeann
Copy link
Contributor Author

emdeann commented Mar 4, 2025

true

@SirzBenjie SirzBenjie enabled auto-merge (squash) March 11, 2025 03:01
@SirzBenjie SirzBenjie requested a review from DayKev March 11, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Bug Major. Game crashing move/ability/interaction
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

5 participants