[Bug] Fix NG crash when ability is reactivated for a Pokemon off the field #5478
+25
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Game won't freeze when neutralizing gas ends on the same turn that a pokemon with a reactivatable ability faints. See https://discord.com/channels/1125469663833370665/1346346653128593518/1346346653128593518
Why am I making these changes?
crashes are bad
What are the changes from a developer perspective?
Simply passing true to
getField()
in NG calls to activate/deactivate abilities to ensure pokemon are activeHow to test the changes?
Use explosion against a pokemon with a legendary weather ability and observe the game not crashing
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: