[Bug] Fix #5358 Abilities that Redirect Moves Consider Move-Typings before Ability Modifiers

[emdeann]

What are the changes the user will see?

Redirection abilities based on type (Lightningrod, Storm Drain) will consider the current type of a move, not its base type. i.e. Lightningrod will not affect normalize thunderbolt, and Storm Drain will affect liquid voice psychic noise.

Why am I making these changes?

Fixes #5358

What are the changes from a developer perspective?

There is already a method to get a move's current type based on the pokemon using it, these abilities just weren't using it. I added the user of the move as an expected parameter (in args) to apply for RedirectMoveAbAttr and replaced allMoves[moveId].type with user.getMoveType(allMoves[moveId]).

I don't forsee any edge cases here as these abilities should always consider the active type of a move, and if getMoveType doesn't always return the correct type then it would be an issue with that method.

Screenshots/Videos

2025-03-02.00-24-05.mp4

How to test the changes?

Automated tests

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

• Has a locales PR been created on the locales repo?
  • If so, please leave a link to it here:
• Has the translation team been contacted for proofreading/translation?

[damocleas]

tested and works for weather ball and other instances I could find

[SirzBenjie]

Good set of tests ✅
Clean, concise code ✅
Added documentation ✅
10/10 would review again