Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][UI/UX] Restore V button in battle #5459

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Mar 1, 2025

Why am I making these changes?

Requested by @Xavion3 here to fix the bug reported on discord here and here.

What are the changes from a developer perspective?

Use the correct key name.

Screenshots/Videos

Before:

Pokerogue.Mozilla.Firefox.2025-03-01.20-58-58.mp4

After:

Pokerogue.Mozilla.Firefox.2025-03-01.21-00-42.mp4

How to test the changes?

Turn on the phone emulator in your browser and mash that V button.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@Wlowscha Wlowscha requested a review from a team as a code owner March 1, 2025 20:07
@Madmadness65 Madmadness65 added UI/UX User interface/-experience related P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Mar 1, 2025
@damocleas damocleas enabled auto-merge (squash) March 1, 2025 21:07
@damocleas damocleas merged commit 8f280be into pagefaultgames:beta Mar 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Bug Minor. Non crashing Incorrect move/ability/interaction UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants