Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][UI/UX] Starter select screen now looks for and displays form-specific abilities #5454

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Mar 1, 2025

Why am I making these changes?

As documented in this video, the starter select screen does not account for alternate forms having different abilities:

Pokerogue.Mozilla.Firefox.2025-03-01.03-10-08.mp4

What are the changes from a developer perspective?

Explicitly check for the ability of the form, rather than the species, whenever there is more than one form.

Screenshots/Videos

After the changes:

Pokerogue.Mozilla.Firefox.2025-03-01.03-11-29.mp4

How to test the changes?

Load a save with all or many unlocks and look around the starter select screen.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@Wlowscha Wlowscha requested a review from a team as a code owner March 1, 2025 02:17
@damocleas damocleas added P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. UI/UX User interface/-experience related labels Mar 1, 2025
@damocleas damocleas merged commit 5c73a1e into pagefaultgames:beta Mar 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants