Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][UI/UX] Restore egg/tm move and passive icons when using filters in Pokédex #5450

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Mar 1, 2025

Why am I making these changes?

As reported on Discord, icons that indicate egg or tm moves ir passives while filtering are not showing up.

What are the changes from a developer perspective?

Code to turn the icons visible when needed had not been included after the refactoring in #5400, it is added now.

Screenshots/Videos

filter_2
fliter_1

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@Wlowscha Wlowscha requested a review from a team as a code owner March 1, 2025 00:05
@Madmadness65 Madmadness65 added UI/UX User interface/-experience related P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. labels Mar 1, 2025
@damocleas damocleas merged commit 7cc5f40 into pagefaultgames:beta Mar 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants