Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX][Bug] Fixing obsolete reference in Pokédex to filteredPokemonContainers #5415

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Wlowscha
Copy link
Contributor

Why am I making these changes?

Hotfix due to a hidden conflict between #5400 and #5372.

What are the changes from a developer perspective?

#5372 introduced a reference to filteredPokemonContainers, which have been removed in #5400 . Referencing filteredPokemonData instead.

Screenshots/Videos

The Pokédex is not crashing anymore and filters are working as expected.
not_crashing

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@Wlowscha Wlowscha requested a review from a team as a code owner February 25, 2025 19:09
@Madmadness65 Madmadness65 added UI/UX User interface/-experience related P1 Bug Major. Game crashing move/ability/interaction labels Feb 25, 2025
@damocleas damocleas merged commit 7a9bede into pagefaultgames:beta Feb 25, 2025
13 checks passed
Jimmybald1 pushed a commit to IBBCalc/Pathing-Tool that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Bug Major. Game crashing move/ability/interaction UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants