Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Text is grey again in delay confirm option menu #5396

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Feb 22, 2025

What are the changes the user will see?

Confirm options with a delay show up as grey text for the duration of the delay, again.

Why am I making these changes?

This was the behavior before #5083. The changes to the option select ui handler in that PR included a shift to BBCodeText objects. An unwanted consequence of this is that, since BBCodeText objects do not support a setAlpha() method, the method previously used to turn the text grey temporarily does not work anymore.

See bug report here and here.

What are the changes from a developer perspective?

The BBCodeText object is wrapped in a new container, and the setAlpha() method of the container is called instead.

Screenshots/Videos

Pokerogue.Mozilla.Firefox.2025-02-22.22-38-00.mp4

How to test the changes?

Start a new run, try to overwrite an existing save slot.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
  • Have I provided screenshots/videos of the changes (if applicable)?

@Wlowscha Wlowscha requested a review from a team as a code owner February 22, 2025 21:45
@Madmadness65 Madmadness65 added UI/UX User interface/-experience related P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. labels Feb 22, 2025
@DayKev DayKev merged commit bd288ad into pagefaultgames:beta Feb 22, 2025
13 checks passed
Jimmybald1 pushed a commit to IBBCalc/Pathing-Tool that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. UI/UX User interface/-experience related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants