[UI/UX] Text is grey again in delay confirm option menu #5396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Confirm options with a delay show up as grey text for the duration of the delay, again.
Why am I making these changes?
This was the behavior before #5083. The changes to the option select ui handler in that PR included a shift to BBCodeText objects. An unwanted consequence of this is that, since BBCodeText objects do not support a setAlpha() method, the method previously used to turn the text grey temporarily does not work anymore.
See bug report here and here.
What are the changes from a developer perspective?
The BBCodeText object is wrapped in a new container, and the setAlpha() method of the container is called instead.
Screenshots/Videos
Pokerogue.Mozilla.Firefox.2025-02-22.22-38-00.mp4
How to test the changes?
Start a new run, try to overwrite an existing save slot.
Checklist
beta
as my base branchnpm run test
)