Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add form changes for Solgaleo, Lunala, & Marshadow cosmetic forms #5344

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

Madmadness65
Copy link
Collaborator

@Madmadness65 Madmadness65 commented Feb 16, 2025

What are the changes the user will see?

Solgaleo, Lunala, and Marshadow will be able to form change into their unique cosmetic forms via their signature moves. These are custom form change methods since the Z-Moves these forms are usually attached to are not planned to be implemented.

Why am I making these changes?

The graphics for these forms were unused, and I wanted to find a reasonable way to implement them, since these forms will not impact gameplay.

What are the changes from a developer perspective?

Added PokemonForm entries for Solgaleo and Lunala so they can use their unique sprites. Entries were added to the form changes to change form when their signature move is used, Party icons needed to be added for Radiant Sun Solgaleo and Full Moon Lunala. Existing variant palettes exist for both forms, but they do lack party icons for the variants.

Screenshots/Videos

Marshadow form changing into Zenith form
zenith.mp4
Solgaleo and Lunala form changing into Radiant Sun and Full Moon forms respectively
sun.moon.mp4

How to test the changes?

Use a Solgaleo, Lunala, or Marshadow with Sunsteel Strike, Moongeist Beam, or Spectral Thief respectively. Switch out the Pokemon to see that it reverts back to normal when recalled.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    - [ ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    - [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

Solgaleo, Lunala, and Marshadow can form change into their unique cosmetic forms via their signature moves. Added PokemonForm entries for Solgaleo and Lunala so they can use their unique sprites.
@Madmadness65 Madmadness65 added Enhancement New feature or request Sprite/Animation For issues/PRs related to graphics labels Feb 16, 2025
@Madmadness65 Madmadness65 requested a review from a team as a code owner February 16, 2025 03:06
DayKev
DayKev previously approved these changes Feb 18, 2025
Copy link
Collaborator

@DayKev DayKev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:wynautshrug:

Wlowscha
Wlowscha previously approved these changes Feb 18, 2025
@Wlowscha Wlowscha dismissed their stale review February 18, 2025 18:16

Should wait until variants are also implemented

@Wlowscha
Copy link
Contributor

As discussed here, this should wait until all three new forms also have variants made. Posting this so that no one else merges by mistake as I was about to do.

@SirzBenjie
Copy link
Member

As discussed here, this should wait until all three new forms also have variants made. Posting this so that no one else merges by mistake as I was about to do.

Can we get an issue tracker for this if there isn't already one?

@Unicornpowerstar
Copy link
Contributor

As discussed here, this should wait until all three new forms also have variants made. Posting this so that no one else merges by mistake as I was about to do.

Issue Momo isnt on the Discord anymore unless another artist tackle this it wont be done.

@Madmadness65 Madmadness65 requested a review from a team as a code owner March 3, 2025 21:22
@Madmadness65 Madmadness65 dismissed stale reviews from DayKev and Unicornpowerstar via 95f0422 March 9, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Sprite/Animation For issues/PRs related to graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants