Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The Daily Run option does not show up in the title menu anymore, instead it appears under New Run with all other options.
Why am I making these changes?
With the incoming #5083, various options in UI menus have been shifted around. Moving the Daily Run option reduces the space taken by the title menu; it also makes things uniform in regard to starting a new run.
What are the changes from a developer perspective?
In
title-phase.ts
, the daily run option has been moved from the title menu to the new run menu. Since now two options are present even before beating classic mode, the options had to be moved around.Adding
globalScene.ui.clearText();
at the beginning ofinitDailyRun()
is necessary to prevent a visual bug; if not, the"menu:selectGameMode"
message does not go away when opening save slots and then pressing cancel to go back to the title page.Additionally, the position of the Player Count text on the title page is now determined dynamically based on the height of the menu instead of using a hard-coded parameter. This will simplify things for any future addition to the options in the title menu.
Screenshots/Videos
Demonstrating the new menu:
https://github.com/user-attachments/assets/62fe4d5f-d22e-4425-a650-ad36d7c8aeb5
Options showing up when classic mode is not beaten:

Demonstrating that player count moves dynamically for a different number of options:

Legacy mode:

Checklist
beta
as my base branchnpm run test
)