Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Moving Daily Run option #5273

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Feb 8, 2025

What are the changes the user will see?

The Daily Run option does not show up in the title menu anymore, instead it appears under New Run with all other options.

Why am I making these changes?

With the incoming #5083, various options in UI menus have been shifted around. Moving the Daily Run option reduces the space taken by the title menu; it also makes things uniform in regard to starting a new run.

What are the changes from a developer perspective?

In title-phase.ts, the daily run option has been moved from the title menu to the new run menu. Since now two options are present even before beating classic mode, the options had to be moved around.
Adding globalScene.ui.clearText(); at the beginning of initDailyRun() is necessary to prevent a visual bug; if not, the "menu:selectGameMode" message does not go away when opening save slots and then pressing cancel to go back to the title page.

Additionally, the position of the Player Count text on the title page is now determined dynamically based on the height of the menu instead of using a hard-coded parameter. This will simplify things for any future addition to the options in the title menu.

Screenshots/Videos

Demonstrating the new menu:
https://github.com/user-attachments/assets/62fe4d5f-d22e-4425-a650-ad36d7c8aeb5

Options showing up when classic mode is not beaten:
new_daily_run

Demonstrating that player count moves dynamically for a different number of options:
players_online_before

Legacy mode:
legacy_pc

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

@Wlowscha Wlowscha requested a review from a team as a code owner February 8, 2025 02:46
@Madmadness65 Madmadness65 added the UI/UX User interface/-experience related label Feb 8, 2025
@damocleas damocleas merged commit 345329a into pagefaultgames:beta Feb 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants