-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Item] Add Deep Sea Scale & Deep Sea Tooth items #5078
Open
Madmadness65
wants to merge
15
commits into
beta
Choose a base branch
from
deep-sea-items
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes Clamperl's evolution method from gender-specific to requiring one of the Deep Sea items to be held.
Would like for the items to be made Great tier |
Also gives every species stat booster item a `rare` boolean to split these items from the rest of the species stat booster items. Updated the existing tests accordingly to account for the split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Adds the Deep Sea Scale and Deep Sea Tooth species-specific items for Clamperl in the Great tier, which also comes with an evolution method change for it to no longer be gender-specific, but instead require one of the Deep Sea items to be held before using a Linking Cord.
Why am I making these changes?
Clamperl's special boosting items were wanted like the other species-specific held items, they just needed a bit more added to it so they could function as part of its evolution too. I am aware that this increases the difficulty in evolving Clamperl, but the boosts the Deep Sea items give, alongside other niche items like Eviolite, and the Deep Sea items specifically being in the Great tier, I feel make up for the additional time spent finding the second item.
What are the changes from a developer perspective?
Two new entries in the
SpeciesStatBoosterItem
list for Deep Sea Scale and Deep Sea Tooth, as well as Clamperl's evolution condition being changed to requiring an instance of one of the Deep Sea items. Species stat booster items have been split between regular in the Great item pool (currently just the Deep Sea Scale and Tooth) and rare in the Ultra item pool (everything else, unchanged from a player's perspective). This should not affect any existing species stat booster items in existing save files.Screenshots/Videos
deepsea.mp4
How to test the changes?
Change the item reward override to either
[{name: "SPECIES_STAT_BOOSTER", type: "DEEP_SEA_SCALE"}, {name: "EVOLUTION_ITEM", type: 1}]
or[{name: "SPECIES_STAT_BOOSTER", type: "DEEP_SEA_TOOTH"}, {name: "EVOLUTION_ITEM", type: 1}]
. Clamperl will not be able to use a Linking Cord until it has one of the Deep Sea items.Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?- [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?Are there any localization additions or changes? If so: