fix(s3): fixed issue with access policy

padok-team · Feb 6, 2023 · d8075a9 · d8075a9
1 parent e6758c9
commit d8075a9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/aws/s3/getter.go b/aws/s3/getter.go
@@ -58,8 +58,12 @@ func GetS3ToPublicBlockAccess(s aws.Config, b []types.Bucket) []S3toPublicBlockA
 			Bucket: aws.String(*bucket.Name),
 		}
 		resp, err := svc.GetPublicAccessBlock(context.TODO(), params)
-		if err != nil || (resp.PublicAccessBlockConfiguration != nil && resp.PublicAccessBlockConfiguration.BlockPublicAcls) {
-			s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, true})
+		if err != nil {
+			if resp.PublicAccessBlockConfiguration != nil && resp.PublicAccessBlockConfiguration.BlockPublicAcls {
+				s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, true})
+			} else {
+				s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, false})
+			}
 		} else {
 			s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, false})
 		}