Added windows specific code to check if mock service is stopped. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You wouldn't believe the fun and games I've had trying to ensure the mock process shuts down nicely on Windows! |
|
Sorry as I am new here, do I have to inform someone to merge this PR? |
|
Matthew will do it when he has time. It will be in his backlog! |
|
Sorry, just for context, I work on the underlying ruby code (not the python). I just keep an eye on the python issues because a lot of the python issues are actually issues with the ruby code. |
|
Sorry for the delay. Thanks for the contribution @shahha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting error while using pact-python in windows 10 'There was an error when stopping the Pact mock service.' Same code was running without any error in Ubuntu.
While digging a bit found out that checking self._process.returncode != 0 does not work with windows as in my case windows was returning return code as 15.
So now for windows I am checking if process still exists using psutil.pid_exists to determine if mock service is stopped or not.