chore(ci): adapt before-build for windows #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JP-Ellis
force-pushed
the
chore/adapt-for-windows
branch
10 times, most recently
from
94b21ec to
511edc3
Compare
The `rm` and `mv` commands don't work well within Windows' default shell. As a result, a separate script for Windows is required. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/adapt-for-windows
branch
2 times, most recently
from
b5737b5 to
afe8988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The
rmandmvcommands don't work well within Windows' default shell. As a result, a separate script for Windows is required.🚨 Breaking Changes🔥 Motivation
Avoid bloat on Windows too (it is fixed for Linux and macOS).
🔨 Test Plan
CI
🔗 Related issues/PRs
None