Move to using the service command with pact-mock-service
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The start/stop commands in pact-mock-service have trouble with Windows because it does not exactly support SIGTERM. The simplest solution is to shift how pact-python runs the mock service to: - Start the mock service using the `service` command - Keep track of the subprocess during pact execution - Use the terminate options from Python's subprocess module to stop the mock service
|
This should resolve #39 |
|
I'm probably going to look at this code to copy/pilfer/... to the NodeJS version. I'll be watching to see how it pans out - great stuff! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start/stop commands in pact-mock-service have trouble with Windows because
it does not exactly support SIGTERM. The simplest solution is to shift how pact-python
runs the mock service to:
servicecommand@mefellows @jslvtr @bethesque