Issue: Cannot supply multiple files to pact-verifier #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When making a change to a public API, it's good practice to provide an upgrade path that does not break any existing users. You could maintain the existing pact_urls in parallel with pact_url, but print a deprecation warning to let the user know to change to the new format. The old pact_urls would then be removed in the next major release, according to semantic versioning practice. |
SimKev2
force-pushed
the
pacturls
branch
2 times, most recently
from
fbfb657 to
01d6261
Compare
|
@bethesque Good idea. I re-enabled multiple for |
|
👍 |
- Updated '--pact-urls' to be a single comma separated string argument - Added '--pact-url' which can be specified multiple times
- PR: Added deprecation warning instead of making api-breaking change
|
Rebased onto master to fix the new version stuff @matthewbalvanz-wf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #21
Note that this will break any existing versions that are using multiple
--pact-urlsarguments@matthewbalvanz-wf