Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: synchronize error when writing pact file, in Ruby 3.2.x #143

Merged
merged 7 commits into from
May 18, 2023

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented May 18, 2023

Noted, in the pact-ruby-standalone upgrade to Ruby 3.2, fixes that :)

Writing pact for Provider to tmp/pacts/consumer-provider.json
ERROR ThreadError: can't be called from trap context\n\t/Users/saf/.rbenv/versions/3.2.2/lib/ruby/3.2.0/timeout.rb:132:in `synchronize'
INFO  going to shutdown ...
INFO  WEBrick::HTTPServer#start done.

@YOU54F YOU54F requested a review from bethesque May 18, 2023 00:20
@YOU54F
Copy link
Member Author

YOU54F commented May 18, 2023

Hey hey, so I am going to merge this and if it breaks the world, we will fix forward. We need to march on to Ruby 3.2, and it saves me from having to downgrade pact-ruby-standalone to use Ruby 3.1.2 (which works but is unnecessary, when master is sitting at 3.2)

Users can always pin, if they get stuck whilst we resolve issues, apologies in advance :)

It will certainly get a decent testing as I roll out the testing against the standalone consumers

@bethesque
Copy link
Member

Thanks Yousaf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants