feat: support linux musl #454
Merged
+143
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
YOU54F
force-pushed
the
feat/linux-musl
branch
from
db2bf12 to
5b9bf9c
Compare
causes issues in musl
musl no likey
add workflow input to allow for conditional testing with tests enabled This will allow end users to at least utilise pact-go with alpine in some capacity and may lead to an inquisitive user working out why we are getting segfaults in the verifier execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #453
having some fairly consistent segfaults exclusively on alpine that need investigating further during provider verifications.
consumer side seems fine.
This PR will enable support for Linux Alpine users.
Support compatibility has been added to the matrix, with caveats
A workflow dispatch action has been created, and all provider verification tests (those tagged with provider) are not tested on alpine. The workflow can be run manually with
SKIP_ALPINE_PROVIDER_TESTSvalue set tofalsewhich is the default for wf dispatch jobs.This will allow end users to at least utilise pact-go with alpine in some capacity and may lead to an inquisitive user working out why we are getting segfaults in the verifier execution
It also allows us as maintainers to quickly test with any new changes, if the issue is solved, by creating reproducible conditions.