Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert unique constraints to primary key declarations #92

Merged
merged 13 commits into from
May 21, 2021
Merged

Convert unique constraints to primary key declarations #92

merged 13 commits into from
May 21, 2021

Conversation

rod-glover
Copy link
Contributor

Resolves #90 , except that it proved difficult (read: not done in this PR) to convert the flag association tables to class declarations.

@rod-glover rod-glover requested a review from corviday May 20, 2021 16:56
corviday
corviday approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@corviday corviday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. More contingency handling via sqlalchemy wizardry.

Wasn't able to run the tests, but they look thorough.

@rod-glover rod-glover merged commit e9c2265 into master May 21, 2021
@rod-glover rod-glover deleted the i90-unique-constraints branch May 21, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corviday corviday corviday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert unique constraints to primary key declarations
2 participants
@rod-glover @corviday