Add obs_raw indexes #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Peculiar; the same tests ( |
rod-glover
force-pushed
the
i87-add-indexes
branch
from
35189b5 to
54173fc
Compare
|
Should be good to go here. |
corviday
approved these changes
May 11, 2021
There was a problem hiding this comment.
Wow, the changes this PR makes are pretty straightforward, but there are just a gajillion contiguencies - different database starting states, different test setups, environments, etc. A lot of complexity, but broad, rather than deep, handling various contingencies and combinations.
It looks great to me, very thoughtful and thorough, though I am not familiar enough with this codebase to guess at what setups or states might additionally need to be covered, which seems the likeliest way there'd be an error here.
| logger.debug(f"Creating index {index_name}") | ||
| op.create_index(index_name, table_name, columns, unique=False, schema=schema_name) | ||
| else: | ||
| logger.debug(f"Index {index_name} already exists; skipping create") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a partial address to #87 , add the following indexes.
mod_time_idxobs_raw_comp_idxobs_raw_history_id_idxobs_raw_id_idxThe new revision follows 7a3b247c577b (current head).
mod_time_idxobs_raw_comp_idxobs_raw_history_id_idxobs_raw_id_idx