Add SET/RESET ROLE to migrations #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... Weirdness with SET ROLE/AUTH and SELECT current_user. See comments.
rod-glover
commented
Feb 5, 2021
|
|
||
|
|
||
| @pytest.mark.usefixtures('new_db_left') | ||
| logger = logging.getLogger("tests") |
There was a problem hiding this comment.
Note: All changes in this file due to Black. No algorithmic changes.
rod-glover
commented
Feb 5, 2021
tests/alembic_migrations/versions/v_4a2f1879293a_create_functions/conftest.py
Outdated
Show resolved
Hide resolved
rod-glover
commented
Feb 5, 2021
rod-glover
commented
Feb 5, 2021
rod-glover
commented
Feb 5, 2021
|
This code has also been run successfully against a test database cloned from |
rod-glover
force-pushed
the
i81-set-role-su
branch
from
7bc7ee4 to
1916709
Compare
corviday
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #81
Note to reviewers: The vast majority of the changes in this PR are documentation, formatting, and test updates. The significant changes are confined to a few lines in:
pycds/alembic/extensions/operation_plugins.pypycds/alembic/versions/4a2f1879293a_create_functions.pypycds/util.pyThis PR wraps revision 42af upgrade operations (create SPs) in a SET/RESET role pair to enable creating SPs with sufficiently high privilege in real databases.
The user in the tests is already at maximum privilege and I have not added infrastructure to create and use a lower-privileged user to test this aspect.Nominally, in tests, all migration operations are executed by a limited-privilege usertestuserand privilege is only escalated to rolepcicdbafor the wrapped operations. However, it proved extremely difficult to verify whether the user was being set properly in tests, so this cannot quite be taken as definitive.