Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions #62

Merged
merged 7 commits into from
Jul 10, 2020
Merged

Add actions #62

merged 7 commits into from
Jul 10, 2020

Conversation

nikola-rados
Copy link

@nikola-rados nikola-rados commented Jul 9, 2020

Resolves #61

Changes

  • Add ci test workflow
  • Add pypi publishing workflow
  • Remove travis & jenkins
  • Update README
  • Mark "slow" tests

Notes

The ci workflow uses postgresql-plpython-9.5 & postgresql-9.5-postgis-2.4 packages rather than their 9.3 counterparts. While these are not exactly the desired package versions, they are the oldest versions that are working. I know we'd like to have the versions perfectly match but I think this is probably ok. The alternative is very clumsy and difficult to maintain.

The changes to the README can be ignored for the most part. I only added new status badges but my IDE continues to remove whitespace from .md files automatically.

@nikola-rados nikola-rados requested a review from rod-glover July 9, 2020 18:45
@nikola-rados nikola-rados self-assigned this Jul 9, 2020
@nikola-rados nikola-rados marked this pull request as draft July 9, 2020 18:55
@nikola-rados nikola-rados marked this pull request as ready for review July 9, 2020 19:45
Copy link
Contributor

@rod-glover rod-glover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes all LGTM. A couple of questions:

  1. How and when do the slow tests get run?
  2. Curiosity more than anything else: Why can't we use the old postgresql 9.3 packages specified in .travis.yml? Did they get removed recently?

TWINE_PASSWORD: ${{ secrets.pcic_at_pypi_password }}
run: |
python setup.py sdist bdist_wheel
twine upload --repository-url https://pypi.pacificclimate.org/ --skip-existing -u $TWINE_USERNAME -p $TWINE_PASSWORD dist/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really nice.

env:
PYCDS_SCHEMA_NAME: other
run: |
py.test -m "not slow" -v --tb=short -k "not weather_anomal" tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When, if ever, do the slow tests get run?

@nikola-rados
Copy link
Author

How and when do the slow tests get run?

The slow tests are run on the master branch. We wanted to exclude them from running on dev branches to prevent it from bogging us down. The current thought is any tests that run for 3+ seconds seconds are considered "slow". We can change this if we find it is excluding to many, but that is the rule of thumb for now.

Curiosity more than anything else: Why can't we use the old postgresql 9.3 packages specified in .travis.yml? Did they get removed recently?

It is not that they have been removed. You can still install and run the tests with those packages. The issue is that the the older packages need access to some directory that is not available to actions for whatever reason. I tried playing around with some permissions to get things to work but couldn't find a solution. The alternative that we were running with in Jenkins was to use custom images with the directory made available. This was becoming difficult to maintain and was hoping we could avoid the by using the slightly newer packages.

@rod-glover
Copy link
Contributor

Those sound like reasonable choices to me. All good. Thanks!

@nikola-rados nikola-rados merged commit 4ede3a3 into master Jul 10, 2020
@nikola-rados nikola-rados deleted the i61-actions branch July 10, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github actions
2 participants