-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions #62
Add actions #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes all LGTM. A couple of questions:
- How and when do the slow tests get run?
- Curiosity more than anything else: Why can't we use the old postgresql 9.3 packages specified in
.travis.yml
? Did they get removed recently?
TWINE_PASSWORD: ${{ secrets.pcic_at_pypi_password }} | ||
run: | | ||
python setup.py sdist bdist_wheel | ||
twine upload --repository-url https://pypi.pacificclimate.org/ --skip-existing -u $TWINE_USERNAME -p $TWINE_PASSWORD dist/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is really nice.
env: | ||
PYCDS_SCHEMA_NAME: other | ||
run: | | ||
py.test -m "not slow" -v --tb=short -k "not weather_anomal" tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When, if ever, do the slow tests get run?
The slow tests are run on the
It is not that they have been removed. You can still install and run the tests with those packages. The issue is that the the older packages need access to some directory that is not available to actions for whatever reason. I tried playing around with some permissions to get things to work but couldn't find a solution. The alternative that we were running with in |
Those sound like reasonable choices to me. All good. Thanks! |
Resolves #61
Changes
ci
test workflowpypi
publishing workflowtravis
&jenkins
README
Notes
The
ci
workflow usespostgresql-plpython-9.5
&postgresql-9.5-postgis-2.4
packages rather than their9.3
counterparts. While these are not exactly the desired package versions, they are the oldest versions that are working. I know we'd like to have the versions perfectly match but I think this is probably ok. The alternative is very clumsy and difficult to maintain.The changes to the
README
can be ignored for the most part. I only added new status badges but my IDE continues to remove whitespace from.md
files automatically.