Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish migration for weather anomaly materialized views #55

Merged
merged 8 commits into from
Feb 6, 2020

Conversation

rod-glover
Copy link
Contributor

@rod-glover rod-glover commented Feb 6, 2020

Resolves #49

This PR This PR adds another set of operations to Alembic for managing materialized views, following the same pattern as for managing functions and views. As for views, there is already a suitable container defined for holding views, namely classes descended from MaterializedViewMixin. We adopt that as the "target" object in view migration operations.

This PR then uses the new view migration operations to create a migration that adds the weather anomaly materialized views to the database.

As with functions and views, the matviews are stored in a per-migration-version directory.

@rod-glover rod-glover changed the title I49 migr matviews Establish migration for weather anomaly materialized views Feb 6, 2020
Copy link

@nikola-rados nikola-rados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment about the command line args, otherwise this looks good. Keep up the good work!

@rod-glover rod-glover merged commit 6ad42ee into master Feb 6, 2020
@rod-glover rod-glover deleted the i49-migr-matviews branch February 6, 2020 22:29
@rod-glover rod-glover restored the i49-migr-matviews branch February 6, 2020 22:30
@rod-glover rod-glover deleted the i49-migr-matviews branch February 6, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Establish migration for matviews
2 participants