Establish migration for utility views #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-rados
suggested changes
Feb 4, 2020
There was a problem hiding this comment.
Nice work @rod-glover. This follows a familiar framework and is clear and understandable. My only comments are down in the test section.
tests/alembic_migrations/versions/v_84b7fc2596d5_add_utility_views/conftest.py
Show resolved
Hide resolved
tests/alembic_migrations/versions/v_84b7fc2596d5_add_utility_views/conftest.py
Show resolved
Hide resolved
tests/alembic_migrations/versions/v_84b7fc2596d5_add_utility_views/test_views.py
Show resolved
Hide resolved
nikola-rados
approved these changes
Feb 5, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48
This PR adds another set of operations to Alembic for managing (creating, replacing, dropping) views, following the same pattern as for managing functions. Unlike functions, there is already a suitable container defined for holding views, namely classes descended from
ViewMixin. We adopt that as the "target" object in view migration operations.This PR then uses the new view migration operations to create a migration that adds "utility" views (for lack of a better name) to the database.
It's worth noting that the definitions of replaceable objects (here, views) from previous migrations must be preserved in order for Alembic to be able to migrate to any arbitrary version. Here we accomplish that by storing the view definitions in a module of PyCDS which is named for the migration version that it supports (
pycds/utility_views/version_84b7fc2596d5). PyCDS exports the latest version of each view to the modulepycds/utility_viewsto make it easy for users to import the view definitions they need. See comments for more information.