-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalize test fixtures #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is still some DRYing up of code that could be done:
|
OK, that's it. As squeaky-clean as it's going to get. |
This proved out by making the implementation of #32 very straightforward (in the testing realm). Since I need to move forward with this sequence of PRs, I am going to merge this one without review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41
The main motivation for this PR is, as noted in #41, is to pave the way for a reasonable implementation of #32 (variable schema name), which is almost complete but foundering on test insanity.
There are now substantially fewer and simpler test fixtures, and they are much more consistent with each other.
Rationalizing the test fixtures led naturally to a hierarchy of test subdirectories, with test-specific fixtures isolated in deeper
conftest.py
files. This makes the relationship of the fixtures to each other and to test code much easier to understand, and the tests are now better organized and more navigable too.Also removed a pile of cruft and orphaned code.
Notes to reviewers:
test_*.py
, and assume (rightly) that they have simply been moved to a new location and wired up to the new, rationalized fixtures.conftest.py
files.