Adds index definitions to the obs_raw table #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS This came up, because we have now created a couple new databases from |
rod-glover
reviewed
Dec 13, 2018
| @@ -185,6 +185,13 @@ class Obs(Base): | |||
| name='time_place_variable_unique'), | |||
| ) | |||
|
|
|||
| # Indexes | |||
| mod_time_idx = Index('mod_time_idx', 'mod_time') | |||
| obs_raw_comp_idx = Index('obs_raw_comp_idx', 'obs_time', 'vars_id', | |||
There was a problem hiding this comment.
Maybe use a more explanatory name, say 'obs_raw_time_vars_history_idx'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obs_rawis generally a big table. Usually on the order of hundreds of millions of rows. Searches on this table require a little assistance so they don't end up doing a sequential scan on the whole table (and take minutes to complete).When we build the BC Provincial Climate Data Set using raw SQL, we put a set of indexes on every column of the table. Those definitions didn't get ported to
pycdswhen we wrote it, so here they are now. Could someone (@rod-glover or @corviday ) take a look at this and see if it makes sense?