Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update view CrmpNetworkGeoserver with variable tags column #194

Merged
merged 11 commits into from
Jan 10, 2024

Conversation

rod-glover
Copy link
Contributor

@rod-glover rod-glover commented Jan 10, 2024

In this PR, we update view CrmpNetworkGeoserver with a variable tags column (unique_variable_tags) carried forward from matview CollapsedVariables, plus an additional column vars_ids likewise.

This PR also extends the documentation with advice on how to write new migrations, particularly migrations that involve replaceable obects.

This completes the work necessary to resolve #180.

@rod-glover rod-glover requested a review from Nospamas January 10, 2024 00:11
Copy link
Contributor

@Nospamas Nospamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small notes

@@ -29,13 +32,12 @@
schema_name = get_schema_name()


# TODO: Use CrmpNetworkGeoserver taken from appropriate revision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this TODO is done.

@rod-glover rod-glover merged commit 569fc02 into master Jan 10, 2024
@rod-glover rod-glover deleted the i-180-crmp_network_geoserver branch January 10, 2024 19:28
Copy link
Contributor

@Nospamas Nospamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query for materialized view collapsed_vars_mv is likely wrong
2 participants