-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update view CrmpNetworkGeoserver with variable tags column #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small notes
@@ -29,13 +32,12 @@ | |||
schema_name = get_schema_name() | |||
|
|||
|
|||
# TODO: Use CrmpNetworkGeoserver taken from appropriate revision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this TODO is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In this PR, we update view
CrmpNetworkGeoserver
with a variable tags column (unique_variable_tags
) carried forward from matviewCollapsedVariables
, plus an additional columnvars_ids
likewise.This PR also extends the documentation with advice on how to write new migrations, particularly migrations that involve replaceable obects.
This completes the work necessary to resolve #180.