Remove dead code warnings for integration tests

See also: https://users.rust-lang.org/t/invalid-dead-code-warning-for-submodule-in-integration-test/80259/2 rust-lang/rust#46379 Signed-off-by: Knut Borchers <[email protected]>
pace-running · Apr 20, 2023 · 8f3e99e · 8f3e99e
1 parent afd095f
commit 8f3e99e
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 16 deletions.
diff --git a/backend/src/repository/payment.rs b/backend/src/repository/payment.rs
@@ -2,7 +2,7 @@ use crate::core::repository::PaymentRepository;
 use crate::schema;
 use diesel::prelude::*;
 use diesel::r2d2::ConnectionManager;
-use diesel::{sql_types, PgConnection, RunQueryDsl};
+use diesel::{PgConnection, RunQueryDsl};
 use r2d2::Pool;
 
 pub struct PostgresPaymentRepository {

diff --git a/backend/tests/admin.rs b/backend/tests/admin.rs
@@ -3,8 +3,8 @@ use pace::models::users::{LoginData, PasswordChangeData};
 use pace::{insert_rejected_transaction, models::rejected_transaction::NewRejectedTransaction};
 use std::collections::HashMap;
 
-mod helpers;
-use crate::helpers::{TestApp, TestDatabase};
+pub mod helpers;
+pub use helpers::{TestApp, TestDatabase};
 
 #[test]
 fn put_rejected_transaction_into_database() {
@@ -263,7 +263,6 @@ async fn delete_rejected_transactions_should_fail_if_user_is_unauthorized() {
     let docker = testcontainers::clients::Cli::default();
     let test_app = TestApp::new(&docker).await;
 
-    let ids = "[1, 2]";
     let result = test_app
         .delete_rejected_transactions("[1, 2]".to_string(), None)
         .await;
@@ -293,7 +292,6 @@ async fn delete_rejected_transactions_should_be_successful_if_authenticated() {
 
     let cookie = test_app.get_admin_cookie().await;
 
-    let ids = "[1, 2]";
     let result = test_app
         .delete_rejected_transactions("[1, 2]".to_string(), Some(cookie))
         .await;

diff --git a/backend/tests/helpers.rs b/backend/tests/helpers.rs
@@ -4,7 +4,6 @@ use diesel::{pg::Pg, PgConnection};
 use diesel_migrations::{embed_migrations, EmbeddedMigrations, MigrationHarness};
 use pace::handlers::theme::ThemeData;
 use r2d2::{Pool, PooledConnection};
-use reqwest::cookie::Cookie;
 use reqwest::{Client, Response};
 use serde_json::Map;
 use std::env;

diff --git a/backend/tests/repository/payment.rs b/backend/tests/repository/payment.rs
@@ -1,8 +1,9 @@
-use crate::helpers::TestDatabase;
 use diesel::RunQueryDsl;
 use pace::core::repository::PaymentRepository;
 use pace::repository::PostgresPaymentRepository;
 
+pub use crate::helpers::TestDatabase;
+
 #[test]
 fn deleted_rejected_transactions_by_ids_should_delete_all_relevant_entries() {
     let cli = testcontainers::clients::Cli::default();

diff --git a/backend/tests/repository/runner.rs b/backend/tests/repository/runner.rs
@@ -4,7 +4,7 @@ use pace::models::runner::{NewRunner, Runner};
 use pace::repository::PostgresRunnerRepository;
 use pace::schema::runners;
 
-use crate::helpers::TestDatabase;
+pub use crate::helpers::TestDatabase;
 
 #[test]
 fn insert_runner_should_store_runner_in_db_if_no_constraints_are_violated() {

diff --git a/backend/tests/repository/user.rs b/backend/tests/repository/user.rs
@@ -1,9 +1,8 @@
 use diesel::RunQueryDsl;
 use pace::core::repository::UserRepository;
-use pace::models::users::User;
 use pace::repository::PostgresUserRepository;
 
-use crate::helpers::TestDatabase;
+pub use crate::helpers::TestDatabase;
 
 #[test]
 fn find_user_by_username_should_return_user_with_given_username_if_present_in_db() {

diff --git a/backend/tests/runners.rs b/backend/tests/runners.rs
@@ -6,8 +6,8 @@ use pace::handlers::runners::{
 };
 use pace::models::runner::create_verification_code;
 
-mod helpers;
-use crate::helpers::{extract_json_values, TestApp};
+pub mod helpers;
+pub use crate::helpers::{extract_json_values, TestApp};
 
 #[actix_web::test]
 async fn create_runner_should_be_successful_if_only_participant_info_is_provided<'a>() {

diff --git a/backend/tests/start_number.rs b/backend/tests/start_number.rs
@@ -3,8 +3,8 @@ use diesel::PgConnection;
 use pace::constants::DENYLIST_START_NUMBERS;
 use pace::models::start_number::next_start_number;
 
-mod helpers;
-use crate::helpers::TestDatabase;
+pub mod helpers;
+pub use crate::helpers::TestDatabase;
 
 // For testing only
 fn restart_start_number(conn: &mut PgConnection) {

diff --git a/backend/tests/theme.rs b/backend/tests/theme.rs
@@ -1,7 +1,8 @@
 use pace::handlers::theme::ThemeData;
 use reqwest::StatusCode;
-mod helpers;
-use crate::helpers::{extract_json_values, TestApp};
+
+pub mod helpers;
+pub use crate::helpers::{extract_json_values, TestApp};
 
 #[actix_web::test]
 async fn get_theme_should_return_theme_settings() {