Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBT implementation in target utils #30

Merged
merged 4 commits into from
Jan 31, 2024
Merged

RBT implementation in target utils #30

merged 4 commits into from
Jan 31, 2024

Conversation

swaroopsarma
Copy link
Contributor

No description provided.

@swaroopsarma swaroopsarma requested a review from saynb January 31, 2024 11:07
include/target-utils/rbt/rbt.h Outdated Show resolved Hide resolved
include/target-utils/rbt/rbt.h Outdated Show resolved Hide resolved
saynb added 3 commits January 31, 2024 12:41
* remove number from BF_RBT_ERR
* convert rbt_node_direction to bf_rbt_node_direction
* convert enum vals to uppercase
* Change APIs to return bf_rbt_node_direction_t instead of int
* few whitespace changes
Copy link
Collaborator

@saynb saynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@V-Hariharan V-Hariharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@saynb saynb merged commit c703f8f into main Jan 31, 2024
2 checks passed
@saynb saynb deleted the rbt-impl branch January 31, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants