Add SPDX-License-Identifier: GPL-2.0-only to Python source files using scapy #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g scapy either by directly importing scapy, or by importing a package that imports scapy. Remove the one Scapy method call in tools/testutils.py that existed, so that it no longer needs to import scapy, reducing the number of Python files that are GPL-2.0-only. Signed-off-by: Andy Fingerhut <[email protected]>
|
If this passes all the tests as I think it will, note that the 13 Python source files that have GPL-2.0-only license identifier added to them are probably the only Python source files in this p4c repo that import scapy, either directly or via importing a package that imports scapy. That's it! I was able to reduce the number by removing the one Scapy method call that was in compare_pkts(). |
|
FYI, here is a similar PR for the p4lang/tutorials repository, where some Python source files import scapy, but most do not: p4lang/tutorials#665 |
Note: Changes may take a few seconds to appear on GitHub Pages. Please refresh the page if you do not see the updates immediately. |
|
I think this is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
either by directly importing scapy, or by importing a package that imports scapy.
Remove the one Scapy method call in tools/testutils.py that existed, so that it no longer needs to import scapy, reducing the number of Python files that are GPL-2.0-only.