Delete associated data when removing sighting #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adzialocha
commented
May 30, 2024
•
adzialocha
commented
- Delete blobs (done automatically via GC in node)
- Delete "Hive Location" documents
- Delete "Used For" documents
sandreae
force-pushed
the
delete-associated-data
branch
from
e633d88 to
c7e0345
Compare
sandreae
approved these changes
May 31, 2024
| @@ -59,3 +63,46 @@ abstract class Paginator<T> { | |||
| return next; | |||
| } | |||
| } | |||
|
|
|||
| Future<List<Map<String, dynamic>>> paginateOverEverything( | |||
There was a problem hiding this comment.
The FetchAll pagination list widget contains similar logic, we could probably reuse this method over there. Will raise a separate issue for that though.
| /// | ||
| /// Even though we're only displaying _one_ hive location per sighting it might | ||
| /// be possible that others exist. To make sure we're cleaning up after ourselves | ||
| /// this method deletes _all known_ hive locations to that peer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.