Improve giflib 5.2.1 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
p-podsiadly
force-pushed
the
giflib
branch
2 times, most recently
from
b0087b8 to
77bf837
Compare
p-podsiadly
reviewed
Jun 27, 2020
| tools.patch(**patch) | ||
|
|
||
| def build(self): | ||
| self._patch_sources() |
There was a problem hiding this comment.
Shouldn't patching be done in source?
There was a problem hiding this comment.
No. Source folder should be untouched. Why? Any change in the recipe will require a new download, which means more time. Keep all patches on build folder, which is a "build cache".
p-podsiadly
force-pushed
the
giflib
branch
2 times, most recently
from
069133d to
8a942e8
Compare
4 tasks
p-podsiadly
force-pushed
the
giflib
branch
2 times, most recently
from
48abbb3 to
d52fdc7
Compare
p-podsiadly
pushed a commit
that referenced
this pull request
Jul 29, 2020
volk: use fixed commit hash
p-podsiadly
pushed a commit
that referenced
this pull request
Jul 29, 2020
Build simdjson 0.4.7 on Linux
p-podsiadly
pushed a commit
that referenced
this pull request
Sep 30, 2020
elfutils: patch automake scripts to fix static + simplify Werror patch
p-podsiadly
pushed a commit
that referenced
this pull request
Sep 30, 2020
Update cmake version to cbor
p-podsiadly
pushed a commit
that referenced
this pull request
Apr 19, 2021
* Add ignition-math * Formatting * Change version_mejor approach * Address review comments * Add import ConanInvalidConfiguration * del fPIC in Windows * Add shared and static support * Add import glob * Unconditially remove files * Address review comments * Remove fPIC option since it's always true * Change test_package.cpp * Change test CMakeLists * Add regex patch * Add friends function Angle definition patch * Revert "Add friends function Angle definition patch" This reverts commit 4e68918. * Explicitly link libc++ * Revert "Explicitly link libc++" This reverts commit f659367. * Don't run git clone + support fPIC + create components (#1) * Add cmake_wrapper * Update recipes/ignition-math/all/CMakeLists.txt Co-authored-by: Anonymous Maarten <[email protected]> * ignition-math: use ignition-cmake (#2) * bump to 6.7.0 * bump 6.7.0 * Apply suggestions from code review Co-authored-by: SpaceIm <[email protected]> * remove pkgconf * Apply suggestions from code review Co-authored-by: SpaceIm <[email protected]> Co-authored-by: Juan Oxoby <[email protected]> Co-authored-by: Anonymous Maarten <[email protected]> Co-authored-by: Juan Oxoby <[email protected]> Co-authored-by: SpaceIm <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 19, 2022
* Initial support for wasmtime package * Fixed build package on Linux * Updates according the comments in review #0 * Update recipes/wasmtime/all/conanfile.py Update license type Co-authored-by: Chris Mc <[email protected]> * Updates according the comments in review #1 * Updates according the comments in review #2 * Updates according the comments in review conan-io#3 * Updates according the comments in review conan-io#4 * Updates according the comments in review conan-io#5 * Next iteration of fixes * Fixed cmake variable C_STANDARD -> CMAKE_C_STANDARD * Added check on minimal version of conan * Used copytree instead of copy individual files * Fixed the build * Added checking for architechure in validate(...) * Updated receipt for new comments from @madebr * Fixed calling method tools.cross_building(...) * Update def package(self) according the comments in review * Updated versions of wasmtime * Updated forgot version ugrade * Fixed sha256sum for macos * Fixed SHA256 for Linux * Updated all SHA256 to proer values Co-authored-by: Chris Mc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, Git didn't move the CMakeLists.txt, instead, it remove and created a new one, even when I used git mv command.