Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --allow-roll-forward to dotnet tool install commands #4619

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Jan 29, 2025

@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 29, 2025

@nvuillam I don't understand the 4 failed checks:

image

Those references no longer exist, I have completely removed all of them:

https://github.com/search?q=repo%3Aoxsecurity%2Fmegalinter%20DotNetToolLinter&type=code

@echoix
Copy link
Collaborator

echoix commented Jan 29, 2025

@nvuillam I don't understand the 4 failed checks:

image

Those references no longer exist, I have completely removed all of them:

https://github.com/search?q=repo%3Aoxsecurity%2Fmegalinter%20DotNetToolLinter&type=code

I doesn't make sense to me either. Unless the code of the repo is mounted in the image, it shouldn't matter

@echoix
Copy link
Collaborator

echoix commented Jan 29, 2025

I'll try to merge main into it to make it retry..

@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 30, 2025

Ping @nvuillam

@echoix
Copy link
Collaborator

echoix commented Jan 30, 2025

If there's a possibility that there's no way to avoid using the old classes with the new repo code of a PR (so it always fails), maybe I would be willing to try to merge it anyways and see if a next PR fails too. It can be tried in a fork too, to merge and see what it does.

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT's probably an issue with the mix between Beta image sources and local sources... let's have a leap of faith :)

@nvuillam nvuillam merged commit d994597 into main Jan 30, 2025
126 of 130 checks passed
@nvuillam nvuillam deleted the fix-dotnet branch January 30, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devskim fails due to missing 8.0.0 after v.8.4 update
3 participants