-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --allow-roll-forward to dotnet tool install commands #4619
Conversation
@nvuillam I don't understand the 4 failed checks: Those references no longer exist, I have completely removed all of them: https://github.com/search?q=repo%3Aoxsecurity%2Fmegalinter%20DotNetToolLinter&type=code |
I doesn't make sense to me either. Unless the code of the repo is mounted in the image, it shouldn't matter |
I'll try to merge main into it to make it retry.. |
Ping @nvuillam |
If there's a possibility that there's no way to avoid using the old classes with the new repo code of a PR (so it always fails), maybe I would be willing to try to merge it anyways and see if a next PR fails too. It can be tried in a fork too, to merge and see what it does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IT's probably an issue with the mix between Beta image sources and local sources... let's have a leap of faith :)
Fixes #4592 #4599 #4600
More information: https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-9/sdk#net-tool-roll-forward
cc @nvuillam @echoix