Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON_RUFF_FORMAT #4329

Merged
merged 7 commits into from
Jan 6, 2025
Merged

PYTHON_RUFF_FORMAT #4329

merged 7 commits into from
Jan 6, 2025

Conversation

nvuillam
Copy link
Member

Fixes #3295

Copy link
Contributor

github-actions bot commented Nov 30, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 1 0 1.68s
⚠️ BASH bash-exec 6 1 0.02s
✅ BASH shellcheck 6 0 0.2s
✅ BASH shfmt 6 0 0 0.7s
✅ COPYPASTE jscpd yes no 3.94s
✅ DOCKERFILE hadolint 129 0 23.4s
✅ JSON jsonlint 20 0 0.41s
✅ JSON v8r 22 0 12.91s
⚠️ MARKDOWN markdownlint 266 0 299 24.62s
✅ MARKDOWN markdown-table-formatter 266 0 0 172.96s
⚠️ PYTHON bandit 214 66 3.07s
✅ PYTHON black 214 0 0 4.89s
✅ PYTHON flake8 214 0 2.15s
✅ PYTHON isort 214 0 0 1.34s
✅ PYTHON mypy 214 0 15.81s
✅ PYTHON pylint 214 0 31.87s
✅ PYTHON ruff 214 0 0 0.49s
✅ REPOSITORY checkov yes no 35.62s
✅ REPOSITORY git_diff yes no 0.82s
⚠️ REPOSITORY grype yes 26 14.73s
✅ REPOSITORY secretlint yes no 11.85s
✅ REPOSITORY trivy yes no 15.63s
✅ REPOSITORY trivy-sbom yes no 0.28s
⚠️ REPOSITORY trufflehog yes 1 53.86s
✅ SPELL cspell 716 0 13.98s
⚠️ SPELL lychee 348 13 15.3s
✅ XML xmllint 3 0 0 0.9s
✅ YAML prettier 160 0 0 4.97s
✅ YAML v8r 102 0 29.83s
✅ YAML yamllint 161 0 2.7s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Nov 30, 2024

How did you plan on communicating the changes? As having it enabled will causes changes that black wants to contradict (on one of my repos I tried this year). There isn't a format that satisfies both at the same time.

What would be our default config?

@nvuillam
Copy link
Member Author

nvuillam commented Dec 5, 2024

@echoix good remark ! :):

I think it would be disabled by default, and could be activated using some variable like PYTHON_DEFAULT_STYLE, like we do for JAVASCRIPT_DEFAULT_STYLE

Copy link
Contributor

github-actions bot commented Jan 5, 2025

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jan 5, 2025
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jan 6, 2025
@nvuillam nvuillam enabled auto-merge (squash) January 6, 2025 22:26
@nvuillam nvuillam disabled auto-merge January 6, 2025 23:06
@nvuillam nvuillam merged commit 7cf565b into main Jan 6, 2025
131 checks passed
@nvuillam nvuillam deleted the features/ruff-format branch January 6, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruff run format command
2 participants