Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: git push auto fixed files #4180

Merged

Conversation

lukelloyd1985
Copy link
Contributor

Following on from PR #4176 to fix crash
Fixes apply_fixes typo

Proposed Changes

Testing git add, commit & push when there are fixed sources files

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@nvuillam
Copy link
Member

@lukelloyd1985 plz solve the error in this PR MegaLinter job, i think there is a syntax error :)

@nvuillam
Copy link
Member

    File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
    File "/github/workspace/megalinter/reporters/UpdatedSourcesReporter.py", line 77
      "[Updated Sources Reporter] Failed to git push auto fixes: " + str(exp.message)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  SyntaxError: invalid syntax. Perhaps you forgot a comma?

@@ -76,6 +75,7 @@ def produce_report(self):
except Exception as exp:
logging.error(
"[Updated Sources Reporter] Failed to git push auto fixes: " + str(exp.message)
Copy link
Member

@nvuillam nvuillam Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukelloyd1985 missing + at the end of this line :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dammit :(

@nvuillam nvuillam merged commit 6f241f1 into oxsecurity:alpha Oct 22, 2024
3 of 5 checks passed
@lukelloyd1985 lukelloyd1985 deleted the 4153-git-push-fixed-source-files branch October 23, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants