Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade revive & Temporary disable cljstyle #3268

Merged
merged 5 commits into from
Jan 7, 2024

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Jan 7, 2024

Related cljstyle issue: greglook/cljstyle#104

Copy link
Contributor

github-actions bot commented Jan 7, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.16s
✅ BASH shellcheck 5 0 0.28s
✅ BASH shfmt 5 0 0 0.56s
✅ COPYPASTE jscpd yes no 4.45s
✅ DOCKERFILE hadolint 127 0 16.98s
✅ JSON eslint-plugin-jsonc 23 0 0 3.86s
✅ JSON jsonlint 21 0 0.26s
✅ JSON v8r 23 0 19.05s
✅ MAKEFILE checkmake 1 0 0.01s
⚠️ MARKDOWN markdownlint 261 0 262 32.25s
✅ MARKDOWN markdown-link-check 261 0 9.58s
✅ MARKDOWN markdown-table-formatter 261 0 0 137.9s
✅ OPENAPI spectral 1 0 1.81s
⚠️ PYTHON bandit 208 64 5.47s
✅ PYTHON black 208 0 0 5.38s
✅ PYTHON flake8 208 0 3.81s
✅ PYTHON isort 208 0 0 1.2s
✅ PYTHON mypy 208 0 16.89s
✅ PYTHON pylint 208 0 17.55s
⚠️ PYTHON pyright 208 352 27.91s
✅ PYTHON ruff 208 0 0 0.62s
✅ REPOSITORY checkov yes no 44.13s
✅ REPOSITORY git_diff yes no 0.53s
⚠️ REPOSITORY grype yes 1 22.54s
✅ REPOSITORY secretlint yes no 12.84s
✅ REPOSITORY trivy yes no 31.41s
✅ REPOSITORY trivy-sbom yes no 8.09s
⚠️ REPOSITORY trufflehog yes 1 20.76s
✅ SPELL cspell 683 0 30.88s
✅ SPELL lychee 341 0 6.15s
✅ XML xmllint 3 0 0 0.56s
✅ YAML prettier 160 0 0 6.83s
✅ YAML v8r 102 0 170.53s
✅ YAML yamllint 161 0 2.34s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bdovaz
Copy link
Collaborator

bdovaz commented Jan 7, 2024

@nvuillam when things like this happen shouldn't we put a // TODO and a comment or a url to the Github issue? mgechev/revive#956

Otherwise we don't know why we have pinned / downgraded to a particular version.

cc @echoix @Kurt-von-Laven

@echoix
Copy link
Collaborator

echoix commented Jan 7, 2024

Normally when I find the issue that caused the downgrade, I subscribe to the issue and also at releases to the project so I know when to act upon. Like for the stylelint sass config guidelines, I undowngraded it the same morning when waking up.

@bdovaz
Copy link
Collaborator

bdovaz commented Jan 7, 2024

Normally when I find the issue that caused the downgrade, I subscribe to the issue and also at releases to the project so I know when to act upon. Like for the stylelint sass config guidelines, I undowngraded it the same morning when waking up.

Yes, I do the same, the TODO and the url was more so that anyone can be put in context and that the knowledge is not only in who found the problem initially.

@nvuillam
Copy link
Member Author

nvuillam commented Jan 7, 2024

indeed, usually i use downgraded_version: true and downgraded_reason: xxxx , I just forgot here, i'll correct that !

@nvuillam nvuillam changed the title Downgrade revive Downgrade revive & Fix cljstyle install Jan 7, 2024
@nvuillam nvuillam changed the title Downgrade revive & Fix cljstyle install Downgrade revive & Temporary disable cljstyle Jan 7, 2024
@nvuillam nvuillam merged commit b2da3a2 into main Jan 7, 2024
128 of 129 checks passed
@nvuillam nvuillam deleted the dependencies/downgrade-revive branch January 7, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants