Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set schedule earlier for auto-update-linters.yml, allow manual runs #3066

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Nov 3, 2023

Allow auto update workflow to be called manually, and start the daily checks earlier. It is easier to review on the same day if it isn’t started too late. Also, scheduled actions can be delayed on periods of high load, like the start of every hour. For example, the 00:00 utc runs in the repo often start at 00:35. Since I would like to be able to review the PRs at least an hour and a half earlier (to restart jobs if needed), and the initial job can take 45 minutes before creating the PR, and that the CI on the PRs take at least 55 mins, if passing on the first try, I suggest at least before 22:00 UTC.

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix temporarily deployed to dev November 3, 2023 00:42 — with GitHub Actions Inactive
@echoix echoix temporarily deployed to dev November 3, 2023 00:42 — with GitHub Actions Inactive
@echoix echoix temporarily deployed to dev November 3, 2023 00:43 — with GitHub Actions Inactive
@echoix echoix temporarily deployed to dev November 3, 2023 00:43 — with GitHub Actions Inactive
@echoix echoix added the github_actions Pull requests that update Github_actions code label Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.02s
✅ BASH shellcheck 5 0 0.12s
✅ BASH shfmt 5 0 0 0.36s
✅ COPYPASTE jscpd yes no 3.32s
✅ DOCKERFILE hadolint 123 0 18.17s
✅ JSON eslint-plugin-jsonc 23 0 0 2.3s
✅ JSON jsonlint 21 0 0.22s
✅ JSON v8r 23 0 14.1s
✅ MAKEFILE checkmake 1 0 0.0s
⚠️ MARKDOWN markdownlint 255 0 11 5.87s
✅ MARKDOWN markdown-link-check 255 0 6.05s
✅ MARKDOWN markdown-table-formatter 255 0 0 37.66s
✅ OPENAPI spectral 1 0 1.5s
⚠️ PYTHON bandit 200 61 2.42s
✅ PYTHON black 200 0 0 4.98s
✅ PYTHON flake8 200 0 2.04s
✅ PYTHON isort 200 0 0 0.77s
✅ PYTHON mypy 200 0 10.68s
✅ PYTHON pylint 200 0 13.6s
⚠️ PYTHON pyright 200 352 21.5s
✅ PYTHON ruff 200 0 0 0.41s
✅ REPOSITORY checkov yes no 37.77s
✅ REPOSITORY git_diff yes no 0.35s
⚠️ REPOSITORY grype yes 1 10.8s
✅ REPOSITORY secretlint yes no 10.26s
✅ REPOSITORY trivy yes no 24.92s
✅ REPOSITORY trivy-sbom yes no 1.28s
⚠️ REPOSITORY trufflehog yes 1 18.85s
✅ SPELL cspell 665 0 24.7s
✅ SPELL lychee 335 0 3.38s
✅ XML xmllint 3 0 0 0.38s
✅ YAML prettier 160 0 0 4.56s
✅ YAML v8r 102 0 173.03s
✅ YAML yamllint 161 0 1.57s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed :)

@nvuillam nvuillam merged commit e30f240 into main Nov 3, 2023
@nvuillam nvuillam deleted the dev/change-schedule branch November 3, 2023 07:10
BryanQuigley pushed a commit to BryanQuigley/megalinter that referenced this pull request Nov 3, 2023
…xsecurity#3066)

* Set schedule earlier for auto-update-linters.yml, allow manual runs

* Change schedule to 21:49 UTC in auto-update-linters.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants