-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not push to docker from dev PRs #2639
Conversation
But now, how do the tests run? |
@echoix as the same docker instance is used to build & to test I assume it will find the image it just built ? (like it does today for eternal contributors from forks ) |
Not when you add a multi platform image in the mix, at least for the last time we tried. There are many kinds of exporters, and the default one cannot do that. |
But for now it should kinda work. However I'd like to still see a real test from a pulled container when it's on the main branch (or about to be in the main/beta branch), to be sure we test what the users will be receiving. |
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 6 | 0 | 0.03s | |
✅ BASH | shellcheck | 6 | 0 | 0.17s | |
✅ BASH | shfmt | 6 | 0 | 0 | 0.43s |
✅ COPYPASTE | jscpd | yes | no | 4.73s | |
✅ DOCKERFILE | hadolint | 116 | 0 | 23.14s | |
✅ JSON | eslint-plugin-jsonc | 23 | 0 | 0 | 2.77s |
✅ JSON | jsonlint | 21 | 0 | 0.27s | |
✅ JSON | v8r | 23 | 0 | 20.06s | |
markdownlint | 307 | 0 | 228 | 197.64s | |
✅ MARKDOWN | markdown-link-check | 307 | 0 | 7.38s | |
✅ MARKDOWN | markdown-table-formatter | 307 | 0 | 0 | 24.57s |
✅ OPENAPI | spectral | 1 | 0 | 1.93s | |
bandit | 188 | 58 | 2.93s | ||
✅ PYTHON | black | 188 | 0 | 0 | 6.43s |
✅ PYTHON | flake8 | 188 | 0 | 2.5s | |
✅ PYTHON | isort | 188 | 0 | 0 | 1.08s |
✅ PYTHON | mypy | 188 | 0 | 10.94s | |
✅ PYTHON | pylint | 188 | 0 | 16.62s | |
pyright | 188 | 301 | 29.58s | ||
✅ PYTHON | ruff | 188 | 0 | 0 | 0.56s |
✅ REPOSITORY | checkov | yes | no | 42.3s | |
✅ REPOSITORY | git_diff | yes | no | 0.43s | |
✅ REPOSITORY | secretlint | yes | no | 18.44s | |
✅ REPOSITORY | trivy | yes | no | 35.08s | |
✅ SPELL | cspell | 612 | 0 | 35.03s | |
vale | 219 | 62 | 40.85s | ||
✅ XML | xmllint | 3 | 0 | 0 | 0.43s |
✅ YAML | prettier | 156 | 0 | 0 | 5.14s |
✅ YAML | v8r | 98 | 0 | 164.92s | |
✅ YAML | yamllint | 157 | 0 | 2.0s |
See detailed report in MegaLinter reports
True :) That will be another story ... to test :) |
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 6 | 0 | 0.02s | |
✅ BASH | shellcheck | 6 | 0 | 0.18s | |
✅ BASH | shfmt | 6 | 0 | 0 | 0.04s |
✅ COPYPASTE | jscpd | yes | no | 4.99s | |
✅ DOCKERFILE | hadolint | 116 | 0 | 22.31s | |
✅ JSON | eslint-plugin-jsonc | 23 | 0 | 0 | 2.52s |
✅ JSON | jsonlint | 21 | 0 | 0.27s | |
✅ JSON | npm-package-json-lint | yes | no | 0.85s | |
✅ JSON | v8r | 23 | 0 | 19.29s | |
markdownlint | 307 | 2 | 228 | 185.2s | |
✅ MARKDOWN | markdown-link-check | 307 | 0 | 7.0s | |
✅ MARKDOWN | markdown-table-formatter | 307 | 2 | 0 | 24.74s |
✅ OPENAPI | spectral | 1 | 0 | 1.82s | |
bandit | 188 | 58 | 3.75s | ||
✅ PYTHON | black | 188 | 0 | 0 | 5.98s |
✅ PYTHON | flake8 | 188 | 0 | 2.67s | |
✅ PYTHON | isort | 188 | 0 | 0 | 0.67s |
✅ PYTHON | mypy | 188 | 0 | 11.46s | |
✅ PYTHON | pylint | 188 | 0 | 17.0s | |
pyright | 188 | 301 | 29.43s | ||
✅ PYTHON | ruff | 188 | 0 | 0 | 0.17s |
✅ REPOSITORY | checkov | yes | no | 42.75s | |
devskim | yes | 913 | 5.64s | ||
✅ REPOSITORY | dustilock | yes | no | 1.83s | |
✅ REPOSITORY | git_diff | yes | no | 0.05s | |
✅ REPOSITORY | secretlint | yes | no | 17.7s | |
✅ REPOSITORY | syft | yes | no | 1.41s | |
✅ REPOSITORY | trivy | yes | no | 31.31s | |
✅ SPELL | cspell | 625 | 0 | 37.32s | |
vale | 219 | 62 | 38.67s | ||
✅ XML | xmllint | 3 | 0 | 0 | 0.03s |
✅ YAML | prettier | 156 | 0 | 0 | 5.06s |
✅ YAML | v8r | 98 | 0 | 159.89s | |
✅ YAML | yamllint | 157 | 0 | 1.86s |
See detailed report in MegaLinter reports
No description provided.