Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #1886

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix typo #1886

merged 1 commit into from
Sep 19, 2022

Conversation

jokay
Copy link
Contributor

@jokay jokay commented Sep 19, 2022

Fixes a documentation typo for bash exec 😉

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@jokay jokay requested a review from nvuillam as a code owner September 19, 2022 13:33
@codecov-commenter
Copy link

Codecov Report

Merging #1886 (3d5e615) into main (c34c321) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
+ Coverage   84.46%   84.49%   +0.02%     
==========================================
  Files         164      164              
  Lines        4372     4372              
==========================================
+ Hits         3693     3694       +1     
+ Misses        679      678       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you.

@Kurt-von-Laven Kurt-von-Laven merged commit 2c3d740 into oxsecurity:main Sep 19, 2022
@nvuillam
Copy link
Member

@Kurt-von-Laven @jokay > must of markdown is automatically generated :)

In that case this file starts with :

<!-- markdownlint-disable MD033 MD041 -->
<!-- @generated by .automation/build.py, please do not update manually -->

So the descriptor file must be updated, else such md update will be overwritten ^^

->

description: If set to `false`, the `bash-exec` linter will report a warning if a shell script is not executable. If set to `true`, the `bash-exec` linter will report an arror instead

@Kurt-von-Laven
Copy link
Collaborator

My bad! Opened the linked PR to address this.

@jokay jokay deleted the feature/fix-bash-exec-docs-typo branch September 21, 2022 11:05
@Kurt-von-Laven Kurt-von-Laven added the documentation Improvements or additions to documentation label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants