Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete DataOneV1 #71

Merged
merged 5 commits into from
Oct 31, 2018
Merged

Delete DataOneV1 #71

merged 5 commits into from
Oct 31, 2018

Conversation

oxinabox
Copy link
Owner

@oxinabox oxinabox commented Oct 26, 2018

@oxinabox
Copy link
Owner Author

the combining failure is because now there is one less generator and the results are different.
Semantically they are the same, but since the different providers do things like http vs https for the website that does change the reference.
So that needs to be regenerated.

@oxinabox
Copy link
Owner Author

oxinabox commented Oct 27, 2018

while fixing this I noticed that our DataDryad generator wasn't working for DOIs, which I fixed,
and added tests.

Also I think this will fail, as I think the DataCite API is down
cf: https://twitter.com/oxinabox_frames/status/1056115555499823105
Update: yes indeed it is down.

@oxinabox
Copy link
Owner Author

Tests passing.
@SebastinSanty do you want to review it?

@SebastinSanty
Copy link
Collaborator

Sure, I'll check

Copy link
Collaborator

@SebastinSanty SebastinSanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oxinabox oxinabox merged commit 81feef1 into master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants