Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust toolchain to nightly-2023-01-19 #2187

Closed
wants to merge 2 commits into from
Closed

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jan 20, 2023

I need this to access a "raw FD" on illumos in this PR: #2176

Apparently this was only a module that was made non-private on illumos rather recently.

@smklein smklein requested review from davepacheco and iliana January 20, 2023 05:44
@iliana
Copy link
Contributor

iliana commented Jan 20, 2023

This doesn't seem to be strictly necessary; this import compiles fine on stable (1.65.0) on illumos:

use std::os::unix::io::RawFd;

The os_fd tracking issue indicates the new path, std::os::fd::RawFd, is meant to unify unix and wasi under the same path since they both have the same concept, but we're not targeting wasi. Unfortunately now you only find the new path in the generated docs.

(It's also not clear to me when this is landing in stable, and I'm weary to merge anything that would impact us moving to a stable toolchain Soon™. The feature gate in the code shows it'll stabilize in 1.66.0 but I didn't see any indication of the stabilization process happening, it almost looks accidental.)

@ahl
Copy link
Contributor

ahl commented Feb 17, 2023

nightly is dead; long live nightly

@ahl ahl closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants