Set host flash Mux back to SP once host is booted #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
reviewed
Dec 8, 2023
|
|
||
| fn set_hf_mux_to_sp(&mut self) { | ||
| if self.hf_mux_state != Some(HfMuxState::SP) { | ||
| let _ = self.hf.set_mux(HfMuxState::SP); |
There was a problem hiding this comment.
I was going to ask what we could or should do if this fails (e.g., should we retry setting the mux to the SP on every valid IPCC message), but it looks like this can't actually fail unless the hf task crashes outright. If hf crashes and restarts, do we know what happens with the mux?
There was a problem hiding this comment.
If hf crashes and restarts, the mux will be set to the SP - that's its default disposition and it explicitly resets the pin. Testing bears this out. I've added a comment, thanks.
jgallagher
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1172