Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Tailwind 3.0 #515

Merged
merged 8 commits into from
Nov 17, 2021
Merged

Use Tailwind 3.0 #515

merged 8 commits into from
Nov 17, 2021

Conversation

david-crespo
Copy link
Collaborator

I mostly want this so we can use stroke-<color> (TW PR), but regardless it's a small change for us and 3.0 proper will be out soon.

Only minor changes to variant order were required. I made an issue about that (tailwindlabs/tailwindcss#6016), which I then figured out was a dupe of tailwindlabs/tailwindcss#6016, which is fixed in tailwindlabs/tailwindcss#6018, which will be in the next alpha.

@vercel
Copy link

vercel bot commented Nov 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oxidecomputer/console-ui-storybook/8EANEQDMhaH5PtrkJEEnobSXKK48
✅ Preview: https://console-ui-storybook-git-tailwind-30-oxidecomputer.vercel.app

@github-actions
Copy link
Contributor

Preview will be deployed at https://console-git-tailwind-3.0.internal.oxide.computer

david-crespo
david-crespo commented Nov 16, 2021
View reviewed changes
tailwind.config.js
* TODO: This isn't respected, need an upstream fix.
* @see https://github.com/tailwindlabs/tailwindcss/issues/3949
*/
variantOrder: ['children', ...defaultConfig.variantOrder, 'svg'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zephraph I think this isn't needed anymore but let me know

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's working, it's not needed 😄. I mean, this never did anything to begin with due to the upstream bug.

david-crespo
david-crespo commented Nov 16, 2021
View reviewed changes
tailwind.config.js Outdated
}),
childrenPlugin,
plugin(({ addVariant }) => addVariant('svg', '& > svg')),
plugin(({ addVariant }) => addVariant('children', '& > *')),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-crespo
Copy link
Collaborator Author

The deploy is failing because there's a . in the branch name, but I don't want to redo the PR with a new branch. I went through all the pages and compared side by side with prod. The variant order things fix the only differences I found.

@david-crespo david-crespo merged commit 0b6db6a into main Nov 17, 2021
@david-crespo david-crespo deleted the tailwind-3.0 branch November 17, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zephraph zephraph zephraph left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-crespo @zephraph