Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_structures): add CodeBuffer::print_bytes_iter_unchecked method #9337

Open
wants to merge 1 commit into
base: 02-24-refactor_data_structures_add_debug_assertion_to_codebuffer_peek_nth_char_back_and_improve_safety_docs
Choose a base branch
from

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 24, 2025

Add CodeBuffer::print_bytes_iter_unchecked which is useful for pushing bytes from an iterator in an efficient manner. This is needed by ESTree serializer, but is also a useful API addition in itself.

Copy link
Contributor Author

overlookmotel commented Feb 24, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Feb 24, 2025
@overlookmotel overlookmotel force-pushed the 02-24-feat_data_structures_add_codebuffer_print_bytes_iter_unchecked_method branch from 8281028 to 6f5aae4 Compare February 24, 2025 17:25
@overlookmotel overlookmotel marked this pull request as ready for review February 24, 2025 17:27
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #9337 will not alter performance

Comparing 02-24-feat_data_structures_add_codebuffer_print_bytes_iter_unchecked_method (33087dd) with 02-24-refactor_data_structures_add_debug_assertion_to_codebuffer_peek_nth_char_back_and_improve_safety_docs (a86b061)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-24-feat_data_structures_add_codebuffer_print_bytes_iter_unchecked_method branch from 6f5aae4 to 33087dd Compare February 24, 2025 17:40
@overlookmotel overlookmotel force-pushed the 02-24-refactor_data_structures_add_debug_assertion_to_codebuffer_peek_nth_char_back_and_improve_safety_docs branch from 8c93db0 to a86b061 Compare February 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant