Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): enable doctests #9297

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore(rust): enable doctests #9297

wants to merge 2 commits into from

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Feb 23, 2025

With Rust Edition 2024 Rustdoc combined tests, we can finally enable doctests!

@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier Area - Prettier A-cfg Area - Control Flow Graph A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 23, 2025
@Boshen
Copy link
Member Author

Boshen commented Feb 23, 2025

Fixing all the doc tests will take a bit of time, PR welcome!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 23, 2025

CodSpeed Performance Report

Merging #9297 will not alter performance

Comparing doctests (9c38374) with main (9bc3017)

Summary

✅ 33 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel will be requested when the pull request is marked ready for review overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing will be requested when the pull request is marked ready for review Dunqing is a code owner

@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur will be requested when the pull request is marked ready for review leaysgur is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-ast-tools Area - AST tools A-cfg Area - Control Flow Graph A-cli Area - CLI A-codegen Area - Code Generation A-editor Area - Editor and Language Server A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-prettier Area - Prettier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen